6 Things to Avoid When Contributing to Open-Source Projects

6 Things to Avoid When Contributing to Open-Source Projects

The post 6 Things to Avoid When Contributing to Open-Source Projects first appeared on Qvault.

With #HacktoberFest being a thing, there has been an influx of devs desperately trying to contribute to their favorite Open-Source projects. Unfortunately, many of these pull requests have been a waste of time, with the maintainers ultimately unable to use the contributions. Maintainers don’t want to waste their time reviewing bad PRs, and contributors don’t want to waste their time writing code that will never make it into production.

Let’s take a look at some common pitfalls that developers fall prey to when working on an open-source project. As a side note, we recently open-sourced the Qvault front-end, so take a look at that if you want to help out.

1. Don’t Start Work Without Approval

If you hop into a Github repo and find something you don’t like, don’t immediately open a pull request. Follow these steps instead:

  • Is there already an issue logged? If not, make one.
  • If there is an issue, reach out to the maintainers (just comment on the issue) and let them know you want to work on it, and give a quick overview of how you will address it.
  • Assuming you have their blessing, start work on your PR.

This will help mitigate the creation of pointless PRs that will never be accepted on the basis of a flawed premise.

2. Pull Requests Should Handle ONE Thing

Don’t open a PR like this:

  • Fixes bug #543
  • Adds new linting rules
  • Includes feature #456

Your PR should do one thing. Small diffs decrease the cognitive load of the reviewer and make it easier to get your code into the main branch. If you have beef with multiple issues in a project then open multiple PRs.

3. Don’t Break Consistency

This one happens the most often to me in my own projects. Well-intentioned developers open pull requests with any of the following annoyances:

  • Omitting semicolons in a project that prefers them
  • Using spaces in a project that has clearly been using tabs
  • Introducing snake_case in a camelCase repo

When you contribute to an existing project, use the existing styling. No one gives two hoots about your preference on the “tabs vs spaces” debate in the context of this pull request.

If you think styling needs to change, see points #1 and #2.

4. Don’t Re-open Known Problems/Solutions

Some codebases have thousands of open issues, take the Go language project, or the nocode repository as an example. No one wants to read your duplicate issue or review your duplicate pull request. Make sure there isn’t an existing open or closed issue for what you are trying to address.

5. Squash Those Commits

Not every project will require (or care) about commit squashing. That said, there are no projects that require not squashing commits. To be on the safe side just give ’em a squash.

6. Be Meaningful

Rewording documentation and other frivolous changes make you look like these assholes. This particularly atrocious example is not only scoped to pointless documentation changes but actually makes the documentation worse.



source https://qvault.io/2020/10/21/6-things-to-avoid-when-contributing-to-open-source-projects/

Comments

Post a Comment

Popular posts from this blog

Why is Exclusive Or (XOR) Important in Cryptography?

Image
If you are getting into cryptography, or just trying to understand the fundamentals, you may have noticed that the exclusive-or operation is used quite often, especially in ciphers. What is XOR ( ⊕ )? XOR, or “exclusive or” operates on binary data. It returns true if both of its inputs are opposites (one false and one true), otherwise, it returns false. An example in go code would be something like: func exclusiveOr(a bool, b bool) bool { return a != b } XOR Cipher – The Perfect Cipher The XOR operation can be used as a simple cipher for encrypting and decrypting messages with a single key. This is known as symmetric encryption. It is interesting to note that if: The key is the same size as the message The key is kept secret and generated truly randomly Then the cipher is impossible to crack. This is known as a one time pad . However, a simple XOR shouldn’t be used in production due to the key length needing to be too long to be practical. Cipher Example A...
Read more

Base64 vs Base58 Encoding

Image
By Lane Wagner –  @wagslane  on Twitter Base64 is one of the most popular encoding formats for representing data. Have some binary data? Base64 encode it for convenient readability and parsing. Base58 is just another encoding format (with 58 characters instead of 64, and has gained popularity largely due to Bitcoin and other cryptocurrencies. When it comes to data encoding, there is typically a trade-off made between: Human Readability: Do humans have a good idea of what is being represented at a glance? Efficient data compression: How many bytes are used to represent the same data? Let’s rank Base58, Base64, and ASCII encoding against each other using these metrics! First: A Note on Binary All data is stored in a raw binary format on computers. These encoding formats (Base64, Base58, and ASCII) are just different ways of reading and writing binary data. For example, in Base64 the binary code 000000 represents the letter A , but in ASCII the binary 00000000 repres...
Read more

(Very) Basic Intro to Hash Functions (SHA-256, MD-5, etc)

Image
This is going to be a basic introduction to hash functions. I will assume most of my audience is here to gain an understanding of why hash functions are used and the basic idea of why they work. My goal is to explain it in a general sense, I will be omitting proofs and implementation details and instead focusing on the high-level principles. Why Use A Hash Function? Hash functions are used all over the internet in order to securely store passwords, find duplicate records, quickly store and retrieve data, and more. For example,  Qvault  uses hashes to extend master passwords into private encryption keys. A longer list of uses here:  https://en.wikipedia.org/wiki/Hash_function#Uses I want to focus on several important features of hash functions, arguably the most important features. Hash functions scramble data deterministically No matter the input, the output of a hash function always has the same size The original data can not be retrieved from the scrambled d...
Read more